Ordering M4.2: Changes to export_to_xml - remove unused answerfiles #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to say, this fix makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gordon,
We recently did upgrade to Moodle 4.2.2 and saw one of the Behat test was failing.
Dynamic properties creation are now deprecated in M4.2 (https://tracker.moodle.org/browse/MDL-77328), because of which the 'Export a Matching question' Behat test was failing with the error "Undefined property: stdClass::$answerfiles". As we don't set/use answerfiles in ordering question type, I have removed that line from the code in export_to_xml function. Could you please review the changes and suggest if this looks fine?
Scenario: 'Export a Matching question'
Error:
Then following "click here" should download between "1700" and "2350" bytes: Error while downloading data from click here (Behat\Mink\Exception\ExpectationException)
Error: Exception - Warning: Undefined property: stdClass::$answerfiles in [dirroot]\question\type\ordering\questiontype.php on line 809
line 157 of \lib\behat\lib.php: Exception thrown
line 809 of \question\type\ordering\questiontype.php: call to behat_error_handler()
line 888 of \question\format.php: call to qtype_ordering->export_to_xml()
line 1538 of \question\format\xml\format.php: call to qformat_default->try_exporting_using_qtypes()
line 1017 of \question\format.php: call to qformat_xml->writequestion()
line 1819 of \lib\questionlib.php: call to qformat_default->exportprocess()
line 5108 of \lib\filelib.php: call to question_pluginfile()
line 44 of \pluginfile.php: call to file_pluginfile()
Thanks,
Anupama